Implemented template metod peel#47
Merged
JohanMabille merged 2 commits intoQuantStack:mainfrom Oct 17, 2025
Merged
Conversation
SandrineP
reviewed
Sep 26, 2025
src/wrapper/refs_wrapper.hpp
Outdated
| } | ||
| }(); | ||
|
|
||
| using resource_type = typename W::resoure_type; |
Collaborator
There was a problem hiding this comment.
There is a missing "c" in the second "resource_type"
ianthomas23
approved these changes
Oct 2, 2025
Member
ianthomas23
left a comment
ianthomas23
left a comment
There was a problem hiding this comment.
Approved, assuming the change proposed by Sandrine is included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SandrineP This will allow you to call peel with the return type that you want. For instance, if you have a reference_wrapper and you want to get the peeled commit from it and store it in a
std::vector<commit_wrapper>:std::vector<commit_wrapper> commit_list = { // ... }; auto head_ref = repo.head(); commit_list[0] = head_ref.peel<git_commit>();